bpo-39649: Remove obsolete check for __args__ in bdb.Bdb.format_stack_entry

[blueyed]

Appears to be obsolete since 75bb54c.

https://bugs.python.org/issue39649

[gvanrossum]

Could you add a news entry? You can probably ignore the Codecov "failure".

[shihai1991]

Shall we add some unittest? in case this logic will be break in future.

[gvanrossum]

Shall we add some unittest? in case this logic will be break in future.

I don't see why -- we're removing logic that was never functional in the first place. There's no need to test for that.

[terryjreedy]

Should this be backported, or does the change reflect a 3.9-only change in f_locals?

[gvanrossum]

Should this be backported, or does the change reflect a 3.9-only change in f_locals?

It can be backported -- after all the commit the OP mentioned that makes this check obsolete happened in 1998.

PS, still waiting for the OP (@blueyed) to add a news entry.

[terryjreedy]

If you want, and approve the code change, I will add a blurb and do the merges.

[gvanrossum]

Do it.

[codecov]

Codecov Report

Merging #18531 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18531      +/-   ##
==========================================
- Coverage   82.20%   82.07%   -0.13%     
==========================================
  Files        1958     1955       -3     
  Lines      589743   584108    -5635     
  Branches    44457    44457              
==========================================
- Hits       484772   479382    -5390     
+ Misses      95308    95102     -206     
+ Partials     9663     9624      -39     

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	30.00% <0.00%> (-65.00%)	⬇️
Lib/distutils/command/bdist_rpm.py	7.63% <0.00%> (-56.88%)	⬇️
Modules/_decimal/libmpdec/umodarith.h	80.76% <0.00%> (-19.24%)	⬇️
Lib/test/test_urllib2net.py	76.92% <0.00%> (-13.85%)	⬇️
Lib/test/test_smtpnet.py	78.57% <0.00%> (-12.86%)	⬇️
Lib/ftplib.py	63.85% <0.00%> (-6.06%)	⬇️
Lib/test/test_ftplib.py	87.11% <0.00%> (-4.72%)	⬇️
Tools/scripts/db2pickle.py	17.82% <0.00%> (-3.97%)	⬇️
Tools/scripts/pickle2db.py	16.98% <0.00%> (-3.78%)	⬇️
Lib/test/test_socket.py	71.94% <0.00%> (-3.87%)	⬇️
... and 339 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33bdbb...361228c. Read the comment docs.

[miss-islington]

Thanks @blueyed for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

[bedevere-bot]

GH-18635 is a backport of this pull request to the 3.8 branch.

[bedevere-bot]

GH-18636 is a backport of this pull request to the 3.7 branch.