Skip to content

fix(doc): set correct RST syntax for c:function #18589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

jd
Copy link
Contributor

@jd jd commented Feb 21, 2020

The current content is not rendered since the syntax is not correct.

The current content is not rendered since the syntax is not correct.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

@JulienPalard the "make suspicious" didnt notice this one.

@vstinner vstinner merged commit d4d17fd into python:master Feb 21, 2020
@miss-islington
Copy link
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-18591 is a backport of this pull request to the 3.8 branch.

@vstinner
Copy link
Member

@jd is a backport to 3.7 needed? I didnt check when the do was added.

miss-islington added a commit that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <[email protected]>
@jd
Copy link
Contributor Author

jd commented Feb 21, 2020

@vstinner yes that needs to be backported to 3.7 too

@JulienPalard
Copy link
Member

@vstinner IIRC the make suspicious mostly spots errors from the initial Latex import, it's more the role of sphinx to spot those ones. I also have an issue opened sphinx side about sphinx not spotting some "obvious" errors that are sometimes spotted sometimes not.

@miss-islington
Copy link
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18593 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <[email protected]>
miss-islington added a commit that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants