-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-39693: tarfile extractfile documentation #18639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39693: tarfile extractfile documentation #18639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
@akuchling Thanks for review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have looks good! Please also update Doc/library/tarfile.rst
with the same information.
Also make sure you are in Misc/ACKS
.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@dorosch, please make the changes requested by @ethanfurman. Thanks! |
@ethanfurman Could you please review changes? |
Thanks @dorosch for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…honGH-18639) Co-authored-by: Andrey Darascheka <[email protected]> (cherry picked from commit ec42789) Co-authored-by: Andrey Doroschenko <[email protected]>
Sorry, @dorosch and @akuchling, I could not cleanly backport this to |
GH-22819 is a backport of this pull request to the 3.9 branch. |
|
…18639) Co-authored-by: Andrey Darascheka <[email protected]> (cherry picked from commit ec42789) Closes bpo-39693.
…honGH-18639) Co-authored-by: Andrey Darascheka <[email protected]>
… during native build of extentions
https://bugs.python.org/issue39693