Skip to content

bpo-38403: Update nuspec file for deprecated field and git repository #18657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

bpo-38403: Update nuspec file for deprecated field and git repository #18657

merged 1 commit into from
Feb 25, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 25, 2020 •
edited by bedevere-bot
Loading

@zooba zooba requested a review from a team as a code owner February 25, 2020 18:45
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #18657 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18657      +/-   ##
==========================================
+ Coverage   82.06%   82.11%   +0.05%     
==========================================
  Files        1956     1955       -1     
  Lines      589514   584171    -5343     
  Branches    44464    44464              
==========================================
- Hits       483809   479717    -4092     
+ Misses      96052    94808    -1244     
+ Partials     9653     9646       -7
Impacted Files Coverage Δ
Modules/_decimal/libmpdec/fnt.c 0.00% <0.00%> (-83.34%) ⬇️
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 337 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8ac57...2fb5f95. Read the comment docs.

@zooba zooba merged commit d644891 into python:master Feb 25, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zooba zooba deleted the bpo-38403 branch February 25, 2020 20:07
@bedevere-bot
Copy link

GH-18660 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d6448919702142123d937a54f20a81aeaf8d2acc 3.7

miss-islington added a commit that referenced this pull request Feb 25, 2020
@miss-islington @zooba
bpo-38403: Update nuspec file for deprecated field and git repository (…
1bbb81b 
…GH-18657)

(cherry picked from commit d644891)

Co-authored-by: Steve Dower <[email protected]>
@sthagen sthagen mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni