Skip to content

[3.8] bpo-39667: Sync zipp 3.0 (GH-18540) #18701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 29, 2020

  • bpo-39667: Improve pathlib.Path compatibility on zipfile.Path and correct performance degradation as found in zipp 3.0

  • 📜🤖 Added by blurb_it.

  • Update docs for new zipfile.Path.open

  • Rely on dict, faster than OrderedDict.

  • Syntax edits on docs

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0aeab5c)

Co-authored-by: Jason R. Coombs [email protected]

https://bugs.python.org/issue39667

* bpo-39667: Improve pathlib.Path compatibility on zipfile.Path and correct performance degradation as found in zipp 3.0

* 📜🤖 Added by blurb_it.

* Update docs for new zipfile.Path.open

* Rely on dict, faster than OrderedDict.

* Syntax edits on docs

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0aeab5c)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington
Copy link
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .

4 similar comments
@miss-islington
Copy link
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #18701 into 3.8 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.8   #18701      +/-   ##
==========================================
+ Coverage   82.08%   82.10%   +0.01%     
==========================================
  Files        1919     1918       -1     
  Lines      582229   576874    -5355     
  Branches    43736    43735       -1     
==========================================
- Hits       477944   473647    -4297     
+ Misses      94716    93656    -1060     
- Partials     9569     9571       +2     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.68% <0.00%> (-13.99%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.72% <0.00%> (-6.08%) ⬇️
Lib/test/test_ftplib.py 87.08% <0.00%> (-4.74%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 72.14% <0.00%> (-3.89%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 331 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c4112...3fa1522. Read the comment docs.

@jaraco
Copy link
Member

jaraco commented Mar 1, 2020

As discussed in this comment, the backward-compatibility concerns in this change need to be carefully considered.

@jaraco jaraco requested a review from ambv March 8, 2020 23:58
@jaraco
Copy link
Member

jaraco commented Mar 9, 2020

@ambv, If you would please take a look at this PR as well as the aforementioned comment explaining my rationale for wanting to make this backward-incompatible change. I think it's possible to not to make this change here, but I think users will benefit more from having this change than leaving this incompatible version in Python 3.8 for perpetuity. Let me know what you think and if there are any questions I can answer. Thanks.

@jaraco
Copy link
Member

jaraco commented Mar 18, 2020

I believe the best path forward is to merge this change. If someone decides otherwise at some point, we can revisit it. I'll give it until the end of the month and then merge it if no objection.

@jaraco
Copy link
Member

jaraco commented Apr 15, 2020

After further consideration, I've decided not to break compatibility for zipfile.Path.open. In 93fd719, I've altered the backport to retain compatibility, while adopting the performance improvements.

@jaraco jaraco removed the request for review from ambv April 15, 2020 18:33
@jaraco jaraco merged commit 3e72de9 into python:3.8 Apr 15, 2020
@miss-islington miss-islington deleted the backport-0aeab5c-3.8 branch April 15, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants