-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[3.8] bpo-39667: Sync zipp 3.0 (GH-18540) #18701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* bpo-39667: Improve pathlib.Path compatibility on zipfile.Path and correct performance degradation as found in zipp 3.0 * 📜🤖 Added by blurb_it. * Update docs for new zipfile.Path.open * Rely on dict, faster than OrderedDict. * Syntax edits on docs Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 0aeab5c) Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco: Status check is done, and it's a success ✅ . |
4 similar comments
@jaraco: Status check is done, and it's a success ✅ . |
@jaraco: Status check is done, and it's a success ✅ . |
@jaraco: Status check is done, and it's a success ✅ . |
@jaraco: Status check is done, and it's a success ✅ . |
Codecov Report
@@ Coverage Diff @@
## 3.8 #18701 +/- ##
==========================================
+ Coverage 82.08% 82.10% +0.01%
==========================================
Files 1919 1918 -1
Lines 582229 576874 -5355
Branches 43736 43735 -1
==========================================
- Hits 477944 473647 -4297
+ Misses 94716 93656 -1060
- Partials 9569 9571 +2
Continue to review full report at Codecov.
|
As discussed in this comment, the backward-compatibility concerns in this change need to be carefully considered. |
@ambv, If you would please take a look at this PR as well as the aforementioned comment explaining my rationale for wanting to make this backward-incompatible change. I think it's possible to not to make this change here, but I think users will benefit more from having this change than leaving this incompatible version in Python 3.8 for perpetuity. Let me know what you think and if there are any questions I can answer. Thanks. |
I believe the best path forward is to merge this change. If someone decides otherwise at some point, we can revisit it. I'll give it until the end of the month and then merge it if no objection. |
After further consideration, I've decided not to break compatibility for |
bpo-39667: Improve pathlib.Path compatibility on zipfile.Path and correct performance degradation as found in zipp 3.0
📜🤖 Added by blurb_it.
Update docs for new zipfile.Path.open
Rely on dict, faster than OrderedDict.
Syntax edits on docs
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0aeab5c)
Co-authored-by: Jason R. Coombs [email protected]
https://bugs.python.org/issue39667