Skip to content

bpo-39778: Add clarification about tp_traverse and ownership #18754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 2, 2020

@pablogsal
Copy link
Member Author

pablogsal commented Mar 2, 2020

Feel free to use the new multi-line suggestion feature of GitHub if you wish to edit the message :)

Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one minor grammar repair - other than that, ship it! 😃

@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6df421f into python:master Mar 3, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2020
…H-18754)

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 6df421f)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

GH-18762 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2020
…H-18754)

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 6df421f)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

GH-18763 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 3, 2020
Automerge-Triggered-By: @pablogsal
(cherry picked from commit 6df421f)

Co-authored-by: Pablo Galindo <[email protected]>
miss-islington added a commit that referenced this pull request Mar 3, 2020
Automerge-Triggered-By: @pablogsal
(cherry picked from commit 6df421f)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal deleted the bpo-39778-2 branch May 19, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants