Skip to content

Updates functools.py with consistent quotes #18825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 7, 2020

I have noticed that ' quotes are used everywhere except this particular case,
which was introduced in #18726

So, this is a trivial fix to enforce better consistency.

Automerge-Triggered-By: @csabella

I have noticed that `'` quotes are used everywhere except this particular case,
which was introduced in python#18726

So, this is a simple fix to enforce better consistency.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sobolevn

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@sobolevn
Copy link
Member Author

sobolevn commented Mar 7, 2020

I have signed CLA, but it says that I have to wait at least one US business day. Ok, let's wait 🙂

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sobolevn!

Although I'll admit that it looks slightly odd to use both single quote and double quote strings in the same list, we typically discourage non-functional changes in the source code (not including large organizational refactors or optimizations). This helps to minimize code churn, makes the revision history easier to read, and maximizes the limited (entirely voluntary) review time. While this one alone may not seem like an issue, it's more about the precedent when you consider the volume of PRs we receive.

If you're looking to make a first contribution, I'd highly recommend checking out the issues on bugs.python.org, particularly ones with the keyword "newcomer friendly" or "easy" [1]. We also welcome improvements to the documentation, including the addition of docstrings to functions/methods that didn't previously have one, comment fixing, and various other improvements to the docs on docs.python.org. Typically, similarly minimal documentation changes are more likely to be merged because they pose less possible downsides and risk. As an example, here was my first merged PR: #14069.

That being said, I'll leave it to the discretion of the maintainer for the functools module, @rhettinger, to decide the best course of action for the PR.


[1] - For convenience, here's a couple of links:
All open "newcomer friendly" issues on bpo.
All open "easy" issues on bpo.

If you'd like to tackle any of the above issues or have any questions, feel free to add me to the "nosy list" of the issue or @ mention me in the PR. :)

Also, I'd recommend checking out the following resource if you haven't already: https://devguide.python.org/#contributing

@aeros aeros added the type-feature A feature request or enhancement label Mar 8, 2020
@rhettinger
Copy link
Contributor

rhettinger commented Mar 10, 2020

Am marking this as approved. Once the CLA is signed, this can be applied.

FWIW, we don't typically accept minor "consistency" patches and instead defer to existing code, so please don't use this acceptance as an indication to make more patches like this. Instead, please look to the tracker for some real bugs to fix :-)

@aeros
Copy link
Contributor

aeros commented Mar 10, 2020

@sobolevn Regarding the CLA status, you may have to manually update it through the CLA assistant heroku app. If it shows that your CLA has been signed, @bedevere-bot will swap the label from CLA not signed to CLA signed.

@sobolevn
Copy link
Member Author

Done!

Thanks a lot!

@miss-islington miss-islington merged commit bd87a7f into python:master Mar 11, 2020
@sobolevn sobolevn deleted the patch-1 branch March 11, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants