-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Updates functools.py with consistent quotes #18825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have noticed that `'` quotes are used everywhere except this particular case, which was introduced in python#18726 So, this is a simple fix to enforce better consistency.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I have signed CLA, but it says that I have to wait at least one US business day. Ok, let's wait 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @sobolevn!
Although I'll admit that it looks slightly odd to use both single quote and double quote strings in the same list, we typically discourage non-functional changes in the source code (not including large organizational refactors or optimizations). This helps to minimize code churn, makes the revision history easier to read, and maximizes the limited (entirely voluntary) review time. While this one alone may not seem like an issue, it's more about the precedent when you consider the volume of PRs we receive.
If you're looking to make a first contribution, I'd highly recommend checking out the issues on bugs.python.org, particularly ones with the keyword "newcomer friendly" or "easy" [1]. We also welcome improvements to the documentation, including the addition of docstrings to functions/methods that didn't previously have one, comment fixing, and various other improvements to the docs on docs.python.org. Typically, similarly minimal documentation changes are more likely to be merged because they pose less possible downsides and risk. As an example, here was my first merged PR: #14069.
That being said, I'll leave it to the discretion of the maintainer for the functools module, @rhettinger, to decide the best course of action for the PR.
[1] - For convenience, here's a couple of links:
All open "newcomer friendly" issues on bpo.
All open "easy" issues on bpo.
If you'd like to tackle any of the above issues or have any questions, feel free to add me to the "nosy list" of the issue or @ mention me in the PR. :)
Also, I'd recommend checking out the following resource if you haven't already: https://devguide.python.org/#contributing
Am marking this as approved. Once the CLA is signed, this can be applied. FWIW, we don't typically accept minor "consistency" patches and instead defer to existing code, so please don't use this acceptance as an indication to make more patches like this. Instead, please look to the tracker for some real bugs to fix :-) |
@sobolevn Regarding the CLA status, you may have to manually update it through the CLA assistant heroku app. If it shows that your CLA has been signed, @bedevere-bot will swap the label from |
Done! Thanks a lot! |
I have noticed that
'
quotes are used everywhere except this particular case,which was introduced in #18726
So, this is a trivial fix to enforce better consistency.
Automerge-Triggered-By: @csabella