Skip to content

[3.8] bpo-39915: Ensure await_args_list is updated according to the order in which coroutines were awaited (GH-18924) #18927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 11, 2020

Create call objects with awaited arguments instead of using call_args which has only last call value.
(cherry picked from commit e553f20)

Co-authored-by: Karthikeyan Singaravelan [email protected]

https://bugs.python.org/issue39915

…n which coroutines were awaited (pythonGH-18924)

Create call objects with awaited arguments instead of using call_args which has only last call value.
(cherry picked from commit e553f20)

Co-authored-by: Karthikeyan Singaravelan <[email protected]>
@miss-islington
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

@tirkarthi
Copy link
Member

@cjw296 It will be helpful to have your review of this bug fix backport.

@cjw296
Copy link
Contributor

cjw296 commented Mar 14, 2020

Sure, but this is just a straight backport of e553f20 so looks good to me?

@cjw296 cjw296 merged commit f6bdac1 into python:3.8 Mar 14, 2020
@miss-islington miss-islington deleted the backport-e553f20-3.8 branch March 14, 2020 07:13
@tirkarthi
Copy link
Member

Thanks Chris :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants