-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-39797 Changes to socketserver.BaseServer's shutdown() method. #18929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39797 Changes to socketserver.BaseServer's shutdown() method. #18929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Generally, for doc-only changes, there is no need to include a NEWS entry so please update the PR to remove it. Also as was noted elsewhere, in general you should just submit one PR and against the master branch (or whatever the highest applicable branch is). If accepted, the core developer will mark the PR to be automatically backported to appropriate maintenance branches. So I'm going to close the PRs you submitted against other branches so you don't need to update them.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
News is not needed for documentation PRs
Thanks. Will do so.
Thanks. I was not sure what to do and so I decided to write to the previous ones. Sorry for that. |
Apologies for closing and reopening the PR. I clicked the wrong button when responding. |
I have made the requested changes; please review again |
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
Thanks @amaajemyfren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-19085 is a backport of this pull request to the 3.8 branch. |
…thonGH-18929) Automerge-Triggered-By: @ned-deily (cherry picked from commit 2de7ac9) Co-authored-by: amaajemyfren <[email protected]>
GH-19086 is a backport of this pull request to the 3.7 branch. |
…thonGH-18929) Automerge-Triggered-By: @ned-deily (cherry picked from commit 2de7ac9) Co-authored-by: amaajemyfren <[email protected]>
…-18929) Automerge-Triggered-By: @ned-deily (cherry picked from commit 2de7ac9) Co-authored-by: amaajemyfren <[email protected]>
…-18929) Automerge-Triggered-By: @ned-deily (cherry picked from commit 2de7ac9) Co-authored-by: amaajemyfren <[email protected]>
https://bugs.python.org/issue39797
Automerge-Triggered-By: @ned-deily