-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-40016: re docstring: Clarify relationship of inline and argument flags #19078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c78a7d
to
1117861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue.
Misc/NEWS.d/next/Library/2020-03-19-19-40-27.bpo-40016.JWtxqJ.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I didn't expect the Spanish Inquisition |
Nobody expects the Spanish Inquisition! @terryjreedy: please review the changes made to this pull request. |
re
moduleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The maxOS failure details were not available, so let us see what happens with retest. Otherwise, I think this ready to merge.
Added: The new Docs/Docs failure makes no sense. Git fetch failed and runner received a shutdown signal. Failed again on re-run. This patch does not touch the regular doc. Even if this text includes blurbs, the change since the previous run should not cause a failure.
@vstinner @pablogsal The Docs/Docs test is failing tonight with a git fetch failure. The only 'doc change' is the news item. Do either of you know what is going on? May I merge anyway? |
Thanks @cool-RR for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
@terryjreedy: Please replace |
…flags (pythonGH-19078) Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <[email protected]>
GH-19161 is a backport of this pull request to the 3.8 branch. |
…flags (pythonGH-19078) Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <[email protected]>
GH-19162 is a backport of this pull request to the 3.7 branch. |
The Travis checks passed, but this was not reported back here. |
…flags (GH-19078) Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <[email protected]>
…flags (GH-19078) Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <[email protected]>
|
https://bugs.python.org/issue40016