-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-39148: enable ipv6 for datagrams in Proactor #19121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62e91bc
to
addad50
Compare
Misc/NEWS.d/next/Windows/2020-03-23-19-07-55.bpo-39148.W1YJEb.rst
Outdated
Show resolved
Hide resolved
addad50
to
2176ea2
Compare
2176ea2
to
840fd33
Compare
Ifdef is not necessary, as AF_INET6 is supported from Windows Vista. Change the raised exception so users are not fooled to think it comes from Windows API.
840fd33
to
3e0f2c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a pretty straightforward fix. Thanks!
Thanks @afflux for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Ifdef is not necessary, as AF_INET6 is supported from Windows Vista, and other code in overlapped.c uses AF_INET6 and is not ifdef'd. Change the raised exception so users are not fooled to think it comes from Windows API. Automerge-Triggered-By: @njsmith (cherry picked from commit 442634c) Co-authored-by: Kjell Braden <[email protected]>
GH-20169 is a backport of this pull request to the 3.8 branch. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Ifdef is not necessary, as AF_INET6 is supported from Windows Vista, and other code in overlapped.c uses AF_INET6 and is not ifdef'd. Change the raised exception so users are not fooled to think it comes from Windows API. Automerge-Triggered-By: @njsmith
Ifdef is not necessary, as AF_INET6 is supported from Windows Vista, and other code in overlapped.c uses AF_INET6 and is not ifdef'd.
Change the raised exception so users are not fooled to think it comes from Windows API.
https://bugs.python.org/issue39148
Automerge-Triggered-By: @njsmith