-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Remove ')' #19146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ')' #19146
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NEWS can be skipped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and welcome @marethyu12! LGTM.
Since this PR involves a simple change that could arguably be fixed with auto-correct, I think we can omit the CLA. But if you do sign it, the amount of time it takes for the PR to me merged will likely be reduced. In order to update the status, check the CLA assistant 24-48 hours after submitting the signed CLA to the PSF.
I'll close and re-open the PR to restart the CI. The Ubuntu failure is definitely unrelated, as it failed in the "Install Dependencies" stage. |
Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
GH-19431 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
GH-19432 is a backport of this pull request to the 3.7 branch. |
I will merge trivial patches that do not contain any creative composition and which therefore could not be copyrighted. Otherwise, I will not. |
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-19433 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
Tests for 3.8 backport failed in Sphinx and ctypes. Rerunning with new backport. |
Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-19451 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
(cherry picked from commit ac2cfe6) Co-authored-by: Jimmy Yang <[email protected]>
No description provided.