Skip to content

Remove ')' #19146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Remove ')' #19146

merged 1 commit into from
Apr 8, 2020

Conversation

marethyu
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@marethyu12

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEWS can be skipped

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and welcome @marethyu12! LGTM.

Since this PR involves a simple change that could arguably be fixed with auto-correct, I think we can omit the CLA. But if you do sign it, the amount of time it takes for the PR to me merged will likely be reduced. In order to update the status, check the CLA assistant 24-48 hours after submitting the signed CLA to the PSF.

@aeros
Copy link
Contributor

aeros commented Mar 25, 2020

I'll close and re-open the PR to restart the CI. The Ubuntu failure is definitely unrelated, as it failed in the "Install Dependencies" stage.

@aeros aeros closed this Mar 25, 2020
@aeros aeros reopened this Mar 25, 2020
@aeros aeros added the docs Documentation in the Doc dir label Mar 25, 2020
@terryjreedy terryjreedy merged commit ac2cfe6 into python:master Apr 8, 2020
@miss-islington
Copy link
Contributor

Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
@bedevere-bot
Copy link

GH-19431 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
@bedevere-bot
Copy link

GH-19432 is a backport of this pull request to the 3.7 branch.

@terryjreedy
Copy link
Member

I will merge trivial patches that do not contain any creative composition and which therefore could not be copyrighted. Otherwise, I will not.

terryjreedy pushed a commit that referenced this pull request Apr 8, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-19433 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
@terryjreedy
Copy link
Member

terryjreedy commented Apr 8, 2020

Tests for 3.8 backport failed in Sphinx and ctypes. Rerunning with new backport.

#19431 (review)

@miss-islington
Copy link
Contributor

Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @marethyu12 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-19451 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
terryjreedy pushed a commit that referenced this pull request Apr 9, 2020
(cherry picked from commit ac2cfe6)

Co-authored-by: Jimmy Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants