bpo-40086: remove test_etree test case

[furkanonder]

https://bugs.python.org/issue40086

[furkanonder]

Since cElementTree was deprecated and removed in Python 3 with 36543. So this test is now skipped. So this test had to be removed.

furkan@manjaro ~/cpython$ ./python -m test test_typing -m test_etree -vvv == CPython 3.9.0a5+ (heads/master:62d21c9d90, Mar 27 2020, 16:10:32) [GCC 9.3.0]
== Linux-5.5.11-1-MANJARO-x86_64-with-glibc2.31 little-endian
== cwd: /home/furkan/cpython/build/test_python_20035
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 1.67 Run tests sequentially
0:00:00 load avg: 1.67 [1/1] test_typing
test_etree (test.test_typing.UnionTests) ... skipped 'cElementTree not found'

---

Ran 1 test in 0.000s

OK (skipped=1)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 183 ms
Tests result: SUCCESS

[serhiy-storchaka]

I think that it would be more correct to not remove the test, but making it working with ElementTree (which uses the C implementation by default).

[furkanonder]

I think that it would be more correct to not remove the test, but making it working with ElementTree (which uses the C implementation by default).

Such a note was written in the test function,Only relevant for Python 2.Wouldn't it be more accurate to remove the test since we are not using python2?

[serhiy-storchaka]

If it is only relevant for Python 2, why it was added at first place? There is no test_typing in Python 2.

[ilevkivskyi]

I think that it would be more correct to not remove the test, but making it working with ElementTree (which uses the C implementation by default).

+1

I think it makes sense to keep the test. IIRC the idea was to test that C functions don't cause runtime exceptions if used as types.

[serhiy-storchaka]

Please keep the comment.

[furkanonder]

Please keep the comment.

Ok

[ilevkivskyi]

Also please see that patchcheck failed because of whitespace issue(s) https://dev.azure.com/Python/cpython/_build/results?buildId=60185&view=logs&j=256d7e09-002a-52d7-8661-29ee3960640e&t=3d7276d3-4e8d-5309-55ad-fb0b172d9925

[serhiy-storchaka]

We usually do not add NEWS entries for minor test changes. They do not affect the end Python user and do not have a useful information for they.

Especially since "This test was skipped" is not informative at all.

[furkanonder]

We usually do not add NEWS entries for minor test changes. They do not affect the end Python user and do not have a useful information for they.

Especially since "This test was skipped" is not informative at all.

Should i delete my NEWS file?

[serhiy-storchaka]

Please delete it.