[3.6] bpo-39073: validate Address parts to disallow CRLF (GH-19007) #19224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow CR or LF in email.headerregistry.Address arguments to guard against header injection attacks. (cherry picked from commit 614f172) Co-authored-by: Ashwin Ramaswami <[email protected]>
|
@epicfaace and @bitdancer: Status check is done, and it's a success ✅ . |
1 similar comment
|
@epicfaace and @bitdancer: Status check is done, and it's a success ✅ . |
|
@epicfaace and @bitdancer: Status check is done, and it's a failure ❌ . |
|
@bitdancer Is this ready to merge? If so, I will merge to 3.6 for you. (Ignore the codecov check failure.) |
vstinner
approved these changes
May 27, 2020
There was a problem hiding this comment.
@bitdancer approved the origin PR #19007 and requested backported to 3.6, 3.7 and 3.8:
#19007 (review)
So yeah, we must backport security fixes to stable branches. Since the CI pass, I merge the PR (by approving it).
|
@ned-deily: Would you mind to merge it? CI tests passed. 3.7 fix is already merged. |
ned-deily
approved these changes
May 27, 2020
|
@ned-deily: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow CR or LF in email.headerregistry.Address arguments to guard against header injection attacks.
(cherry picked from commit 614f172)
Co-authored-by: Ashwin Ramaswami [email protected]
https://bugs.python.org/issue39073