bpo-23890: Fix ref cycles in TestCase.assertRaises() #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
approved these changes
Feb 20, 2017
|
Do the new tests fail without the fix? It isn't immediately clear to me how the fix works, I imagine it's round clearing the references that would be kept alive in the frame though the traceback. If the tests fail without the fix and pass with them then the fix looks good to me. |
|
good work
…On Feb 21, 2017 2:37 PM, "Michael Foord" ***@***.***> wrote:
Do the new tests fail without the fix? It isn't immediately clear to me
how the fix works, I imagine it's round clearing the references that would
be kept alive in the frame though the traceback. If the tests fail without
the fix and pass with them then the fix looks good to me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#193 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYpBUEtRGCXFxJH6RInSLYi9rJiitI-hks5re2cNgaJpZM4MGBPv>
.
|
|
"Do the new tests fail without the fix?" yes it does :-)
|
ncoghlan
approved these changes
Feb 23, 2017
|
Well that's just far too straightforward an approach to fixing this :) |
bpo-23890: unittest.TestCase.assertRaises() now manually breaks a reference cycle to not keep objects alive longer than expected.
|
I rebased my change to fix the usual merge conflict on Misc/NEWS. |
|
3.6 backport: #858 |
vstinner
changed the title
vstinner
added a commit
that referenced
this pull request
Jun 15, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Dec 27, 2018
The macros PyTasklet_CheckExact(op) and PyChannel_CheckExact(op) contained a reference to a non existing variable.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 20, 2019
The macros PyTasklet_CheckExact(op) and PyChannel_CheckExact(op) contained a reference to a non existing variable. (cherry picked from commit 4599c9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-23890: unittest.TestCase.assertRaises() now manually breaks a
reference cycle to not keep objects alive longer than expected.