-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-40176: Improve error messages for unclosed string literals #19346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This message is still a bit jargon-y, I think Rust's error message in this case is pretty nice:
|
That definitely looks more simpler to those who unfamiliar with parser jargon. I'm not sure if we should still use EOF/EOL when needed or not though. |
c75e26e
to
0b6386d
Compare
c7b3048
to
4c24faa
Compare
4c24faa
to
fcecf4b
Compare
as a data point my (non-cs) students always get confused by the EOF and EOL abbreviation. PyPy's message is: |
we actually don't use EOF/EOL anymore, just "unterminated string literal" |
ah great (sorry, hadn't read the diff yet, just saw the earlier comment) |
Misc/NEWS.d/next/Core and Builtins/2021-01-20-22-31-01.bpo-40176.anjyWw.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feel free to land once you address the minor comment
@isidentical: Status check is done, and it's a success ✅ . |
…nGH-19346) Automerge-Triggered-By: GH:isidentical
https://bugs.python.org/issue40176
Automerge-Triggered-By: GH:isidentical