-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-84388: Expose NCURSES_EXT_FUNCS #19392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@serhiy-storchaka the tests from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not be more reliable to use hasattr(curses, 'set_escdelay')
? AFAIK set_escdelay
and set_tabsize
are supported in the NetBSD curses, so we may add their support with non-ncurses implementations.
@serhiy-storchaka do you have a source for me that when was they introduced (or was they always available)? Because for the current implementation, we only support ncurses. cpython/Modules/_cursesmodule.c Line 3258 in f453221
|
After digging through the internet, I couldn't find any relevant information about this (when was they introduced, how can I check their existance or not etc). We might want to go with a config variable (like HAVE_CURSES_TABSIZE etc. but looks like it is a bit overkill. I'll change the tests according to a |
@isidentical Could you resolve the conflict? |
The following commit authors need to sign the Contributor License Agreement: |
@@ -5219,6 +5219,10 @@ cursesmodule_exec(PyObject *module) | |||
} | |||
SetDictInt("KEY_MIN", KEY_MIN); | |||
SetDictInt("KEY_MAX", KEY_MAX); | |||
|
|||
#ifdef NCURSES_EXT_FUNCS | |||
SetDictInt("NCURSES_EXT_FUNCS", NCURSES_EXT_FUNCS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a conditional constant, we should probably say that it's conditional in the docs, shouldn't we?
I have doubts that this will be useful.
|
https://bugs.python.org/issue40207