Skip to content

[3.8] Document missing methods of ssl.SSLObject (GH-19400) #19407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

miss-islington
Copy link
Contributor

Co-authored-by: Rémi Lapeyre [email protected]
(cherry picked from commit 74e1b6b)

Co-authored-by: Rémi Lapeyre [email protected]

Co-authored-by: Rémi Lapeyre <[email protected]>
(cherry picked from commit 74e1b6b)

Co-authored-by: Rémi Lapeyre <[email protected]>
@miss-islington
Copy link
Contributor Author

@remilapeyre and @tiran: Status check is done, and it's a failure ❌ .

@csabella
Copy link
Contributor

@tiran, @remilapeyre, is this just waiting for the approval to finish the backport? Thanks!

@remilapeyre
Copy link
Contributor

@tiran I think this PR is ready to be merged :)

@tiran
Copy link
Member

tiran commented Jun 16, 2020

CI is failing :(

@tiran tiran self-assigned this Jun 16, 2020
@remilapeyre
Copy link
Contributor

remilapeyre commented Jun 16, 2020

It looks like it's failing for an unrelated change:

/Users/remi/src/cpython/Doc/c-api/buffer.rst:92:Error in declarator or parameters
Invalid C declaration: Expected identifier in nested name. [error at 5]
  void \*buf
  -----^
make[1]: *** [build] Error 2
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.

It has since been fixed and merging origin/3.8 in this branch fixes the issue but I don't think I can push on this PR to fix it thought.

Edit: yes, it was fixed in 37a257c

@miss-islington miss-islington merged commit 12bb0b6 into python:3.8 Jun 29, 2020
@miss-islington miss-islington deleted the backport-74e1b6b-3.8 branch June 29, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants