Skip to content

[3.8] bpo-40112: distutils test_search_cpp: Fix logic to determine if C compiler is xlc on AIX (GH-19225) #19408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 7, 2020

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt [email protected]

https://bugs.python.org/issue40112

…piler is xlc on AIX (pythonGH-19225)

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@aixtools and @vstinner: Status check is done, and it's a failure ❌ .

@aixtools
Copy link
Contributor

aixtools commented Apr 8, 2020

@aixtools and @vstinner: Status check is done, and it's a failure ❌ .

Does not look relelated to the change:

======================================================================
ERROR: test_load_dll_with_flags (ctypes.test.test_loading.LoaderTest) [WinDLL('_sqlite3.dll', winmode=0)]

Traceback (most recent call last):
File "D:\a\1\s\lib\ctypes\test\test_loading.py", line 140, in should_pass
subprocess.check_output(
File "D:\a\1\s\lib\subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "D:\a\1\s\lib\subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['D:\a\1\s\PCbuild\amd64\python.exe', '-c', "from ctypes import *; import nt;WinDLL('_sqlite3.dll', winmode=0)"]' returned non-zero exit status 1.

@vstinner vstinner closed this Apr 8, 2020
@miss-islington miss-islington deleted the backport-76db37b-3.8 branch April 8, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants