Skip to content

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr #19430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2020
Merged

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr #19430

merged 3 commits into from
May 16, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Apr 8, 2020 •
edited by miss-islington
Loading

CuriousLearner
CuriousLearner reviewed Apr 18, 2020
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Overall the changes look okay to me.

ericsnowcurrently
ericsnowcurrently requested changes May 12, 2020
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

I left a few comments about phrasing in the docs and NEWS entry.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

CuriousLearner
CuriousLearner approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

ericsnowcurrently
ericsnowcurrently approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. LGTM

@miss-islington miss-islington merged commit 6b6092f into python:master May 16, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@ZackerySpytz @arturoescaip
bpo-39075: types.SimpleNamespace no longer sorts attributes in its re…
00a75c1 
…pr (pythonGH-19430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZackerySpytz @bedevere-bot @ericsnowcurrently @tirkarthi @CuriousLearner @the-knights-who-say-ni @miss-islington