Skip to content

Improved documentation for BUILD_CONST_KEY_MAP #19454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2020
Merged

Improved documentation for BUILD_CONST_KEY_MAP #19454

merged 2 commits into from
Apr 13, 2020

Conversation

laike9m
Copy link
Contributor

@laike9m laike9m commented Apr 10, 2020 •
edited by miss-islington
Loading

Example

>>> dis.dis("{1: a, 2: b, 3: c}")
  1           0 LOAD_NAME                0 (a)
              2 LOAD_NAME                1 (b)
              4 LOAD_NAME                2 (c)
              6 LOAD_CONST               0 ((1, 2, 3))
              8 BUILD_CONST_KEY_MAP      3
             10 RETURN_VALUE

Automerge-Triggered-By: @zhangyangyu

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 10, 2020
@laike9m
Copy link
Contributor Author

laike9m commented Apr 10, 2020

@zhangyangyu

@zhangyangyu
Copy link
Member

Fix the failed CI plz:

[1] library/dis.rst:847: trailing whitespace
[1] library/dis.rst:848: trailing whitespace

@laike9m
Copy link
Contributor Author

laike9m commented Apr 11, 2020

There's some issue with the CI, it never shows "finished", despite that it actually has. Someone should really look into it...

@zhangyangyu zhangyangyu reopened this Apr 13, 2020
@zhangyangyu zhangyangyu merged commit 85dd6bb into python:master Apr 13, 2020
@miss-islington
Copy link
Contributor

Thanks @laike9m for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 13, 2020
@laike9m @miss-islington
Improved documentation for BUILD_CONST_KEY_MAP (pythonGH-19454)
830ad49 
(cherry picked from commit 85dd6bb)

Co-authored-by: laike9m <[email protected]>
@bedevere-bot
Copy link

GH-19495 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 13, 2020
@laike9m @miss-islington
Improved documentation for BUILD_CONST_KEY_MAP (pythonGH-19454)
5443061 
(cherry picked from commit 85dd6bb)

Co-authored-by: laike9m <[email protected]>
@bedevere-bot
Copy link

GH-19496 is a backport of this pull request to the 3.7 branch.

@laike9m
Copy link
Contributor Author

laike9m commented Apr 13, 2020

Thanks!

miss-islington added a commit that referenced this pull request Apr 13, 2020
@miss-islington
[3.7] Improved documentation for BUILD_CONST_KEY_MAP (GH-19454) (GH…
0a9ec9f 
…-19496)

(cherry picked from commit 85dd6bb)


Co-authored-by: laike9m <[email protected]>

Automerge-Triggered-By: @zhangyangyu
miss-islington added a commit that referenced this pull request Apr 13, 2020
@miss-islington
[3.8] Improved documentation for BUILD_CONST_KEY_MAP (GH-19454) (GH…
ee691b0 
…-19495)

(cherry picked from commit 85dd6bb)


Co-authored-by: laike9m <[email protected]>

Automerge-Triggered-By: @zhangyangyu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@laixintao laixintao laixintao approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laike9m @zhangyangyu @miss-islington @bedevere-bot @laixintao @the-knights-who-say-ni