bpo-40260: revert refactor of file_info tuple #19595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by passing in an fp that is opened in "rb". This fixes problems seen on Windows where the source code is not decoded as utf-8 but as the code page default for the user, cp1252 for example. Add three new tests to test_modulefinder.py to excercise the decoding of source code. Always write the test source as bytes to avoid using locale.getpreferredencoding() as the encoding. test_coding_default_utf8 - designed to fail if decoded with cp1252 test_coding_explicit_utf8 - designed to fail if decoded with cp1252 test_coding_explicit_cp1252 - designed to fail if decoded with utf-8
Remove the mode in file_info that is usused.
Debian relies on the subclassing ModuleFinder and load_module call to access info in the file_info tuple.
zooba
approved these changes
Apr 20, 2020
|
Thanks @barry-scott for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 20, 2020
(cherry picked from commit 9b0b5d2) Co-authored-by: Barry <[email protected]>
|
GH-19621 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 20, 2020
(cherry picked from commit 9b0b5d2) Co-authored-by: Barry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian relies on the subclassing ModuleFinder
and load_module call to access info in the file_info
tuple.
https://bugs.python.org/issue40260