Skip to content

bpo-39849: Enable assertions in _testcapimodule.c and _testinternalcapi.c #19623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2020
Merged

bpo-39849: Enable assertions in _testcapimodule.c and _testinternalcapi.c #19623

merged 2 commits into from
Apr 20, 2020
+6 −0

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Apr 20, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 mentioned this pull request Apr 20, 2020
Closed
vstinner
vstinner reviewed Apr 20, 2020
View reviewed changes
vstinner
vstinner approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

corona10
corona10 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I 've also checked on my local machine, no warning is now showing.

@corona10 corona10 merged commit 5dd21f5 into python:master Apr 20, 2020
@shihai1991
Copy link
Member Author

Thanks, folks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihai1991 @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot