Skip to content

bpo-40334: Use old compiler when compile mode is func_type #19692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

bpo-40334: Use old compiler when compile mode is func_type #19692

merged 1 commit into from
Apr 23, 2020

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 23, 2020 •
edited
Loading

This is invoked by mypy, using ast.parse(source, "<func_type>", "func_type"). Since the new grammar doesn't yet support the func_type_input start symbol we must use the old compiler in this case to prevent a crash.

https://bugs.python.org/issue40334

@gvanrossum gvanrossum requested a review from lysnikolaou April 23, 2020 22:21
lysnikolaou
lysnikolaou approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gvanrossum gvanrossum merged commit bc28805 into master Apr 23, 2020
@gvanrossum gvanrossum deleted the fix-func-type branch April 23, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gvanrossum @lysnikolaou @the-knights-who-say-ni @bedevere-bot