Skip to content

bpo-40484: Document compiler flags under AST module #19885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2020
Merged

bpo-40484: Document compiler flags under AST module #19885

merged 5 commits into from
Oct 19, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented May 3, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 3, 2020
@isidentical isidentical requested a review from pablogsal May 3, 2020 14:13
pablogsal
pablogsal reviewed May 3, 2020
View reviewed changes
hauntsaninja
hauntsaninja reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small grammar nits! :-)

isidentical and others added 2 commits May 16, 2020 04:36
@isidentical @hauntsaninja
apply suggestions
859d310 
Co-authored-by: Shantanu <[email protected]>
@isidentical @hauntsaninja
apply suggestions
bf04af9 
Co-authored-by: Shantanu <[email protected]>
@isidentical
Copy link
Member Author

Two small grammar nits! :-)

Thanks @hauntsaninja!

@isidentical isidentical requested a review from pablogsal May 17, 2020 02:08
pablogsal
pablogsal reviewed May 17, 2020
View reviewed changes
pablogsal
pablogsal reviewed May 17, 2020
View reviewed changes
@isidentical isidentical requested a review from pablogsal May 22, 2020 00:05
@isidentical isidentical requested a review from JulienPalard July 18, 2020 10:46
@taleinat
Copy link
Contributor

Ping, @pablogsal?

@pablogsal pablogsal merged commit 1559389 into python:master Oct 19, 2020
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Oct 19, 2020
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 19, 2020
@bedevere-bot
Copy link

GH-22758 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@isidentical @miss-islington
bpo-40484: Document compiler flags under AST module (pythonGH-19885)
a4df257 
Co-authored-by: Pablo Galindo <[email protected]>
Co-authored-by: Shantanu <[email protected]>
(cherry picked from commit 1559389)

Co-authored-by: Batuhan Taskaya <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 19, 2020
@miss-islington @isidentical
bpo-40484: Document compiler flags under AST module (GH-19885) (GH-22758
a358a0a 
)

Co-authored-by: Pablo Galindo <[email protected]>
Co-authored-by: Shantanu <[email protected]>
(cherry picked from commit 1559389)

Co-authored-by: Batuhan Taskaya <[email protected]>

Co-authored-by: Batuhan Taskaya <[email protected]>
@rffontenelle
Copy link
Contributor

@isidentical Hey there. I notice the new strings for translation in library/functions and one changed raised doubts. The current line (first of a long paragraph):

The optional argument *flags* and *dont_inherit* controls which

replaced this previous line:

The optional arguments *flags* and *dont_inherit* control which

Link: https://github.com/python/cpython/blame/master/Doc/library/functions.rst#L262

Was this plural-to-singular change intentional? If yes, would you please clarify?

@isidentical
Copy link
Member Author

Was this plural-to-singular change intentional?

Looks like an oversight. Would you mind sending a PR to fix that?

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@isidentical @pablogsal
@hauntsaninja @adorilson
bpo-40484: Document compiler flags under AST module (pythonGH-19885)
29804aa 
Co-authored-by: Pablo Galindo <[email protected]>
Co-authored-by: Shantanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@pablogsal pablogsal pablogsal approved these changes

@JulienPalard JulienPalard Awaiting requested review from JulienPalard

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@isidentical @taleinat @miss-islington @bedevere-bot @rffontenelle @pablogsal @hauntsaninja @the-knights-who-say-ni