Skip to content

[doc] Remove references to obsolete BuildApplet on macOS. #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

andresdelfino
Copy link
Contributor

No description provided.

@tirkarthi
Copy link
Member

cc: @ned-deily

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino
Copy link
Contributor Author

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

@ned-deily: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ned-deily May 21, 2020 11:58
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and catching the other reference.

@ned-deily ned-deily changed the title [doc] Update MacPython version [doc] Remove references to obsolete BuildApplet on macOS. May 21, 2020
@ned-deily ned-deily merged commit 7864f11 into python:master May 21, 2020
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 21, 2020
@bedevere-bot
Copy link

GH-20304 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
ned-deily pushed a commit that referenced this pull request May 21, 2020
miss-islington added a commit that referenced this pull request May 21, 2020
miss-islington added a commit that referenced this pull request May 21, 2020
) (GH-20306)

(cherry picked from commit 7864f11)


Co-authored-by: Andre Delfino <[email protected]>

Automerge-Triggered-By: @ned-deily
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@andresdelfino andresdelfino deleted the fix_macpython_version branch July 13, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants