bpo-40651: Bugfix of the LRU implementation based on OrderedDict in the collections document
#20139
Conversation
…in the `collections` module documents. Signed-off-by: Dongfang Qu <[email protected]>
| @@ -1161,6 +1161,8 @@ variants of :func:`functools.lru_cache`:: | |||
| return value | |||
|
|
|||
| def __setitem__(self, key, value): | |||
| if key in self: | |||
| self.move_to_end(key) | |||
| super().__setitem__(key, value) | |||
| if len(self) > self.maxsize: | |||
There was a problem hiding this comment.
I think this part could be replaced by self.popitem(last=False) now.
There was a problem hiding this comment.
Yes, you are right.
It is cleaner to remove the oldest entry by self.popitem(last=False).
At the same time, It is working correctly.
Do you suggest I update it in this pull request?
Not sure about the conventions here.
Normally we are only supposed to change the code directly related to the issue.
There was a problem hiding this comment.
I don't know, I think popitem() was added in Python3 so this block of code needed to be compatible with Python 2 until this year.
Let's wait for @rhettinger review, I can change it in another PR if he thinks it's needed.
|
Thanks @qudongfang for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…thonGH-20139) (cherry picked from commit bb8635c) Co-authored-by: qudongfang <[email protected]>
bpo-40651: Bugfix of the
LRUimplementation based onOrderedDictin thecollectionsmodule documents.It didn't consider the calls to
__setitem__method as usage.https://bugs.python.org/issue40651