Skip to content

Fix the URL to fishshell.com #20251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

Fix the URL to fishshell.com #20251

merged 1 commit into from
May 20, 2020

Conversation

jcgoble3
Copy link
Contributor

@jcgoble3 jcgoble3 commented May 20, 2020 •
edited by miss-islington
Loading

Automerge-Triggered-By: @Mariatta

@jcgoble3 jcgoble3 requested a review from vsajip as a code owner May 20, 2020 03:56
Mariatta
Mariatta approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Mariatta Mariatta changed the title Replace hijacked URL with current one Fix the URL to fishshell.com May 20, 2020
@miss-islington miss-islington merged commit da7d1f0 into python:master May 20, 2020
@miss-islington
Copy link
Contributor

Thanks @jcgoble3 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2020
@jcgoble3 @miss-islington
Fix the URL to fishshell.com (pythonGH-20251)
150b802 
(cherry picked from commit da7d1f0)

Co-authored-by: Jonathan Goble <[email protected]>
@bedevere-bot
Copy link

GH-20252 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 20, 2020
@miss-islington
Copy link
Contributor

Sorry, @jcgoble3, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da7d1f04086598a29f77bd452beefe847d038344 3.8

@miss-islington miss-islington self-assigned this May 20, 2020
@miss-islington
Copy link
Contributor

Sorry @jcgoble3, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da7d1f04086598a29f77bd452beefe847d038344 3.7

miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington @jcgoble3
Fix the URL to fishshell.com (GH-20251)
51025e0 
(cherry picked from commit da7d1f0)

Co-authored-by: Jonathan Goble <[email protected]>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@jcgoble3 @arturoescaip
Fix the URL to fishshell.com (pythonGH-20251)
a32fd6b
@jcgoble3 jcgoble3 deleted the jcgoble3-patch-1 branch April 4, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@vsajip vsajip Awaiting requested review from vsajip

Assignees

@miss-islington miss-islington

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcgoble3 @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni