Skip to content

[3.6] bpo-40719 Add pt-br switcher to the Documentation website #20301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2020

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented May 21, 2020

@rougeth
Copy link
Contributor

rougeth commented May 21, 2020

Does it need to be backported to 2.7 as well, right? :)

@JulienPalard JulienPalard changed the title bpo-40719 Add pt-br switcher to the Documentation website [3.6] bpo-40719 Add pt-br switcher to the Documentation website May 21, 2020
@JulienPalard
Copy link
Member

LGTM.

But it's a backport of #16924 and should probably be mentionned as so, but I bet a cherry-pick won't do so I don't really care, are we strict about this @ned-deily?

@ned-deily
Copy link
Member

3.6 is in the security-fix-only stage of its life cycle until end-of-life at the end of 2021. If the translations are there, I don't see a problem publishing them as long as they don't generate a lot of new issues. At the moment, I believe we are still rebuilding the 3.6 docs daily but that could stop again before end-of-life so any updates to the translations would not necessarily be published for some time; we would try to make sure the docs get republished whenever there is a new security release. Also, I see that the other active branches also have Simplified Chinese available. Is that translation available for 3.6 and, if so, should it also be enabled?

@rffontenelle
Copy link
Contributor Author

rffontenelle commented May 22, 2020

FWIW, I didn't create a backport to 2.7 (to solve the other part of bpo-40719) because I thought you core devs would rather call a bot via a "needs-backport" label. If I should create the backport manually, please let me know.

p.s. Sorry if this should have been a backport-type PR. Duly noted for next contribution.

@JulienPalard
Copy link
Member

I believe we are still rebuilding the 3.6 docs daily

That's right.

Also, I see that the other active branches also have Simplified Chinese available. Is that translation available for 3.6 and, if so, should it also be enabled?

I don't see a 3.6 branch in the zh-cn repository so I'd say no. (https://docs.python.org/zh-cn/3.6/ is translated by using the 3.7 translations).

@ned-deily ned-deily merged commit 763b193 into python:3.6 May 23, 2020
@rffontenelle rffontenelle deleted the patch-2 branch August 20, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants