bpo-39301: State that floor division is used for right shift operations #20347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
approved these changes
May 24, 2020
|
One thought: while we're here, could we remove the "without overflow check" part? I have no idea what it means, and I suspect no-one else does either. It may have made sense before long integers were the norm (though even then, I'm not sure what it means). |
|
@ZackerySpytz Do you want to remove the "without overflow check" wording in this PR? If not, I'll merge this one and make a separate PR for changing that wording. |
rhettinger
approved these changes
May 25, 2020
|
This looks good. Please do remove the "without overflow check" wording as well. |
mdickinson
added
needs backport to 3.6
needs backport to 3.9
|
Thanks @ZackerySpytz for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2020
…ns (pythonGH-20347) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-20414 is a backport of this pull request to the 3.9 branch. |
|
GH-20415 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2020
…ns (pythonGH-20347) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2020
…ns (pythonGH-20347) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-20416 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2020
…ns (pythonGH-20347) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-20417 is a backport of this pull request to the 3.6 branch. |
|
Ah, 3.6 is in security mode; I'll close that backport. |
mdickinson
pushed a commit
that referenced
this pull request
May 26, 2020
…ns (GH-20347) (GH-20414) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Zackery Spytz <[email protected]>
mdickinson
pushed a commit
that referenced
this pull request
May 26, 2020
…ns (GH-20347) (GH-20415) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]>
mdickinson
pushed a commit
that referenced
this pull request
May 26, 2020
…ns (GH-20347) (GH-20416) * bpo-39301: State that floor division is used for right shift operations * Remove "without overflow check" (cherry picked from commit af7553a) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Zackery Spytz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39301