bpo-40334: Support suppressing of multiple optional variables in Pegen #20367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title suggest that multiple optional variables do not work, but that's not true isn't it? What happens is that we are not suppressing compiler warnings, no? If I am correct, is ok with merging this without a test |
gvanrossum
approved these changes
May 24, 2020
lysnikolaou
approved these changes
May 24, 2020
isidentical
changed the title
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-20368 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
May 24, 2020
GH-20367) (cherry picked from commit cba5031) Co-authored-by: Batuhan Taskaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C generator would produce
_opt_var_1,_opt_var_2etc. for multiple optional variables in the same context. This patch makes the C generator to support multiple optional variables.https://bugs.python.org/issue40334