bpo-40767: Allow pure Wayland to get default XDG web browser #20382

jtheoof · 2020-05-25T12:10:31Z

Would be nice to backport to python 3.7+. I don't think it's worth the hassle to backport this all the way down to 3.10. But I'll let the maintainers decide.

This is hard to test because the test setup already includes this environment variable

Let me know if something doesn't match the PR guidelines. This is my first PR in the python source code.

https://bugs.python.org/issue40767

Automerge-Triggered-By: @orsenthil

the-knights-who-say-ni · 2020-05-25T12:10:34Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jtheoof

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

jtheoof · 2020-05-25T12:24:53Z

I'm not sure if this deserves to be in the news. Would gladly take feedback from maintainers.
Just signed the CLA, should be reflected next business day.

corona10

[3.x] bpo-xxxxx: XXXXX (GH-XXXX) title forms are only allowed for backport patch.
And the backport patch will be automatically opened by the bot ;)

So I change the PR title.

jtheoof · 2020-05-26T16:30:04Z

Might take longer than expected for the CLA check to validate. In the meantime, can someone tell me if I should update the news entry?

remilapeyre · 2020-05-26T16:42:26Z

Hi @jtheoof, thanks for the PR !

This is a user visible change so I think it will need a NEWS entry.
I think this qualify as a bugfix so it should be backported to 3.7.

jtheoof · 2020-05-27T01:57:04Z

I've added a blurb for the news. All checks are ✔️ Hopefully this is backported to 3.7 🤞

Misc/NEWS.d/next/Library/2020-05-26-21-25-34.bpo-40767.jw964B.rst

…H-20382)

remilapeyre

Thanks @jtheoof!

jtheoof · 2020-06-01T16:55:36Z

@remilapeyre Do you know what I should do to get some attention and get this reviewed by core members?

remilapeyre · 2020-06-01T18:22:01Z

Hi @jtheoof, as far as I can tell your PR looks good and there isn't anything missing. There is a long backlog of PR to review, the core developpers will get to it eventually but it can take some time.

miss-islington · 2020-06-03T12:42:35Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2020-06-03T12:42:35Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2020-06-03T12:42:35Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2020-06-03T12:42:37Z

Thanks @jtheoof for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2020-06-03T12:42:58Z

GH-20607 is a backport of this pull request to the 3.9 branch.

bedevere-bot · 2020-06-03T12:43:06Z

GH-20608 is a backport of this pull request to the 3.8 branch.

…H-20382) Would be nice to backport to python 3.7+. I don't think it's worth the hassle to backport this all the way down to 3.10. But I'll let the maintainers decide. This is hard to test because the test setup already includes this [environment variable](https://github.com/python/cpython/blob/master/Lib/test/pythoninfo.pyGH-L292) Let me know if something doesn't match the PR guidelines. This is my first PR in the python source code. (cherry picked from commit c822efe) Co-authored-by: Jeremy Attali <[email protected]>

bedevere-bot · 2020-06-03T12:43:12Z

GH-20609 is a backport of this pull request to the 3.7 branch.

…H-20382) Would be nice to backport to python 3.7+. I don't think it's worth the hassle to backport this all the way down to 3.10. But I'll let the maintainers decide. This is hard to test because the test setup already includes this [environment variable](https://github.com/python/cpython/blob/master/Lib/test/pythoninfo.pyGH-L292) Let me know if something doesn't match the PR guidelines. This is my first PR in the python source code. (cherry picked from commit c822efe) Co-authored-by: Jeremy Attali <[email protected]>

Would be nice to backport to python 3.7+. I don't think it's worth the hassle to backport this all the way down to 3.10. But I'll let the maintainers decide. This is hard to test because the test setup already includes this [environment variable](https://github.com/python/cpython/blob/master/Lib/test/pythoninfo.pyGH-L292) Let me know if something doesn't match the PR guidelines. This is my first PR in the python source code. (cherry picked from commit c822efe) Co-authored-by: Jeremy Attali <[email protected]>

…H-20382) Would be nice to backport to python 3.7+. I don't think it's worth the hassle to backport this all the way down to 3.10. But I'll let the maintainers decide. This is hard to test because the test setup already includes this [environment variable](https://github.com/python/cpython/blob/master/Lib/test/pythoninfo.py#L292) Let me know if something doesn't match the PR guidelines. This is my first PR in the python source code.

the-knights-who-say-ni added the CLA not signed label May 25, 2020

bedevere-bot added the awaiting review label May 25, 2020

jtheoof mentioned this pull request May 25, 2020

google search opens in the wrong browser Ulauncher/Ulauncher#530

Closed

corona10 changed the title ~~[3.7] bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)~~ bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382) May 25, 2020

corona10 changed the title ~~bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)~~ bpo-40767: Allow pure Wayland to get default XDG web browser May 25, 2020

corona10 reviewed May 25, 2020

View reviewed changes

csabella removed the CLA not signed label May 26, 2020

the-knights-who-say-ni added the CLA not signed label May 26, 2020

the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 26, 2020

jtheoof force-pushed the fix/40767/webbrowser-wayland branch from 27459c9 to 3cdf494 Compare May 27, 2020 01:27

remilapeyre reviewed May 27, 2020

View reviewed changes

Misc/NEWS.d/next/Library/2020-05-26-21-25-34.bpo-40767.jw964B.rst Outdated Show resolved Hide resolved

bpo-40767: Allow pure Wayland to get default XDG web browser (pythonG…

62b1460

…H-20382)

jtheoof force-pushed the fix/40767/webbrowser-wayland branch from 3cdf494 to 62b1460 Compare May 28, 2020 01:27

remilapeyre approved these changes May 28, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 28, 2020

orsenthil approved these changes Jun 3, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jun 3, 2020

orsenthil added 🤖 automerge labels Jun 3, 2020

orsenthil added needs backport to 3.8 needs backport to 3.9 only security fixes labels Jun 3, 2020

miss-islington merged commit c822efe into python:master Jun 3, 2020

bedevere-bot removed awaiting merge needs backport to 3.9 only security fixes labels Jun 3, 2020

bedevere-bot removed the needs backport to 3.8 label Jun 3, 2020

bedevere-bot removed the needs backport to 3.7 label Jun 3, 2020

Uh oh!

bpo-40767: Allow pure Wayland to get default XDG web browser #20382

bpo-40767: Allow pure Wayland to get default XDG web browser #20382

Uh oh!

Conversation

jtheoof commented May 25, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented May 25, 2020

Recognized GitHub username

Uh oh!

jtheoof commented May 25, 2020

Uh oh!

corona10 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtheoof commented May 26, 2020

Uh oh!

remilapeyre commented May 26, 2020

Uh oh!

jtheoof commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

jtheoof commented Jun 1, 2020

Uh oh!

remilapeyre commented Jun 1, 2020

Uh oh!

miss-islington commented Jun 3, 2020

Uh oh!

miss-islington commented Jun 3, 2020

Uh oh!

miss-islington commented Jun 3, 2020

Uh oh!

miss-islington commented Jun 3, 2020

Uh oh!

bedevere-bot commented Jun 3, 2020

Uh oh!

bedevere-bot commented Jun 3, 2020

Uh oh!

bedevere-bot commented Jun 3, 2020

Uh oh!

Uh oh!

jtheoof commented May 25, 2020 •

edited by miss-islington

Loading

corona10 left a comment •

edited

Loading

jtheoof commented May 27, 2020 •

edited

Loading