Skip to content

[3.9] bpo-40246: Fix test_fstring when run with the old parser #20402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

[3.9] bpo-40246: Fix test_fstring when run with the old parser #20402

merged 1 commit into from
May 26, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented May 25, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 25, 2020
@lysnikolaou lysnikolaou requested a review from pablogsal May 25, 2020 23:18
@pablogsal
Copy link
Member

@lysnikolaou This does not affect 3.10?

@lysnikolaou
Copy link
Member Author

It currently does, but I don't think we need to fix that, since the old parser will be removed some time before the 3.10 release.

@pablogsal pablogsal merged commit 6cb0ad2 into python:3.9 May 26, 2020
@pablogsal
Copy link
Member

It currently does, but I don't think we need to fix that, since the old parser will be removed some time before the 3.10 release.

💥 I am waiting to unleash the destruction PR 😉

@lysnikolaou
Copy link
Member Author

Looking forward to that.

@lysnikolaou lysnikolaou deleted the fix-test-fstring branch May 26, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot