-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-40849: Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag #20463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40849: Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag #20463
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I've signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open an issue on bugs.python.org. Also, this change should have a news entry.
Bug report created at https://bugs.python.org/issue40849 |
Added myself to ACKS to make patchcheck happy. |
@l0x-c0d3z We still don't have your contributor agreement in the database. It's possible that it was not assigned to your GH account correctly. |
@l0x-c0d3z, please see the previous comments about signing the CLA. Without a signed CLA, this PR will be closed. Thank you. |
The tool for checking the CLA shows that it is signed, so we'll need to see why the bot keeps flagging it as not signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot does not recognize your CLA. Could you please verify that you used the correct GH account and that the email address from your commit matches GH settings?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Zackery Spytz <[email protected]>
6f07251
to
dc750b7
Compare
Ok, rewrote the commit history to change the emails, and the knights have now given their blessing. I have made the requested changes; please review again |
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Knight Bedevere is picky.
This short PR exposes an openssl flag that wasn't exposed. I've also updated to doc to reflect the change. It's heavily inspired by 990fcaa.
https://bugs.python.org/issue40849
Automerge-Triggered-By: GH:tiran