Skip to content

bpo-30621: import json before using json module #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

suketa
Copy link
Contributor

@suketa suketa commented Jun 10, 2017

In Input and Output in Python tutorial, json module is used without import json.

@mention-bot
Copy link

@suketa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @ezio-melotti to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@suketa suketa force-pushed the fix_tutorial_load_json_at_first_in_Input_and_Output branch 2 times, most recently from 211da72 to 2834258 Compare June 10, 2017 09:23
In python tutorial Input and Output, use json module without import
json.
@suketa suketa force-pushed the fix_tutorial_load_json_at_first_in_Input_and_Output branch from 2834258 to 0c85c0d Compare June 10, 2017 09:25
@suketa suketa changed the title import json before using json module bpo-30621: import json before using json module Jun 10, 2017
@Mariatta Mariatta added needs backport to 2.7 docs Documentation in the Doc dir labels Jun 11, 2017
@Mariatta Mariatta merged commit 1dbce04 into python:master Jun 12, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 12, 2017
 import json before using json module
(cherry picked from commit 1dbce04)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 12, 2017
 import json before using json module
(cherry picked from commit 1dbce04)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 12, 2017
 import json before using json module
(cherry picked from commit 1dbce04)
@Mariatta
Copy link
Member

It's a trivial change, so I'm overriding the CLA requirement.
Thanks @suketa and congrats on your first contribution to CPython 🎉

Mariatta added a commit that referenced this pull request Jun 12, 2017
import json before using json module
(cherry picked from commit 1dbce04)
Mariatta added a commit that referenced this pull request Jun 12, 2017
import json before using json module
(cherry picked from commit 1dbce04)
Mariatta added a commit that referenced this pull request Jun 12, 2017
import json before using json module
(cherry picked from commit 1dbce04)
@suketa suketa deleted the fix_tutorial_load_json_at_first_in_Input_and_Output branch December 3, 2017 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants