bpo-41044: generate a valid python parser for opt+seq rules #20995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Jun 20, 2020
| # Note trailing comma (if there isn't already one, | ||
| # which can occur when rules have both repeat0 and optional | ||
| # marker, e.g: [rule*]) | ||
| if call.endswith(","): |
There was a problem hiding this comment.
Hummmm, not a find on relying on the generated code to reason about the grammar structure (I know that we do it in other places but we have been removing those as it makes it more difficult to reason about). In this case I have to say that is pretty straightforward so it may be fine.
pablogsal
reviewed
Jun 20, 2020
pablogsal
reviewed
Jun 20, 2020
Co-authored-by: Pablo Galindo <[email protected]>
pablogsal
approved these changes
Jun 20, 2020
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 20, 2020
…nGH-20995) Co-authored-by: Pablo Galindo <[email protected]> (cherry picked from commit 55460ee) Co-authored-by: Batuhan Taskaya <[email protected]>
|
GH-21008 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 20, 2020
) Co-authored-by: Pablo Galindo <[email protected]> (cherry picked from commit 55460ee) Co-authored-by: Batuhan Taskaya <[email protected]>
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
…nGH-20995) Co-authored-by: Pablo Galindo <[email protected]>
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
…nGH-20995) Co-authored-by: Pablo Galindo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41044