Skip to content

bpo-41056: Fix reference to deallocated stack in pathconfig (Coverity) #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Jun 20, 2020

Reported by Coverity. (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.

https://bugs.python.org/issue41056

Automerge-Triggered-By: @tiran

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)
@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.8 needs backport to 3.9 only security fixes labels Jun 20, 2020
@gpshead gpshead closed this Jun 21, 2020
@gpshead gpshead reopened this Jun 21, 2020
@gpshead gpshead requested a review from tiran June 21, 2020 19:54
@gpshead gpshead changed the title bpo-41056: Fix Coverity issues reported in pathconfig. bpo-41056: Fix reference to deallocated stack in pathconfig (Coverity) Jun 21, 2020
@miss-islington miss-islington merged commit 81328f3 into python:master Jun 22, 2020
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-21039 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 22, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2020
pythonGH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
(cherry picked from commit 81328f3)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

GH-21041 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81328f30703bd7225e7e73aedb0994a7293ce190 3.7

@miss-islington miss-islington self-assigned this Jun 22, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2020
pythonGH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
(cherry picked from commit 81328f3)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Jun 22, 2020
GH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
(cherry picked from commit 81328f3)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Jun 22, 2020
GH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
(cherry picked from commit 81328f3)

Co-authored-by: Gregory P. Smith <[email protected]>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
pythonGH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
pythonGH-21013)

Reported by Coverity.  (CID 1457554 RETURN_LOCAL)

path0 is assigned as a pointer to this right before it goes out of scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants