Skip to content

bpo-41192: Fix some broken anchors for audit events #21310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

gousaiyang
Copy link
Contributor

@gousaiyang gousaiyang commented Jul 4, 2020

Fix broken anchors for cpython.run_startup, ctypes.call_function and poplib.putline audit events.

https://bugs.python.org/issue41192

@gousaiyang gousaiyang requested a review from a team as a code owner July 4, 2020 02:04
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 4, 2020
Copy link
Contributor

@akuchling akuchling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks fine to me. I verified that the anchors were initially broken, and are fixed after the patch is applied.

@akuchling akuchling self-assigned this Oct 19, 2020
@akuchling akuchling added the needs backport to 3.9 only security fixes label Oct 19, 2020
@akuchling akuchling merged commit ebc8c38 into python:master Oct 19, 2020
@bedevere-bot
Copy link

@akuchling: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 19, 2020
@bedevere-bot
Copy link

GH-22767 is a backport of this pull request to the 3.9 branch.

akuchling pushed a commit that referenced this pull request Oct 19, 2020
@gousaiyang gousaiyang deleted the bpo-41192-fix-anchors branch October 19, 2020 16:35
@gousaiyang
Copy link
Contributor Author

Should we also backport this to 3.8? Since all the audit events related to this patch were introduced in 3.8 (see this audit events table which contains links with previously broken anchors).

@miss-islington
Copy link
Contributor

Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22770 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
akuchling pushed a commit that referenced this pull request Oct 19, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants