-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-41192: Fix some broken anchors for audit events #21310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks fine to me. I verified that the anchors were initially broken, and are fixed after the patch is applied.
@akuchling: Please replace |
Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
…21310) (cherry picked from commit ebc8c38) Co-authored-by: Saiyang Gou <[email protected]>
GH-22767 is a backport of this pull request to the 3.9 branch. |
…GH-22767) (cherry picked from commit ebc8c38) Co-authored-by: Saiyang Gou <[email protected]>
Should we also backport this to 3.8? Since all the audit events related to this patch were introduced in 3.8 (see this audit events table which contains links with previously broken anchors). |
Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-22770 is a backport of this pull request to the 3.8 branch. |
…21310) (cherry picked from commit ebc8c38) Co-authored-by: Saiyang Gou <[email protected]>
…GH-22770) (cherry picked from commit ebc8c38) Co-authored-by: Saiyang Gou <[email protected]>
Fix broken anchors for
cpython.run_startup
,ctypes.call_function
andpoplib.putline
audit events.https://bugs.python.org/issue41192