Skip to content

bpo-41332: Added missing connect_accepted_socket() to AbstractEventLoop #21533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2020
Merged

bpo-41332: Added missing connect_accepted_socket() to AbstractEventLoop #21533

merged 3 commits into from
Nov 26, 2020

Conversation

agronholm
Copy link
Contributor

@agronholm agronholm commented Jul 18, 2020 •
edited by bedevere-bot
Loading

@agronholm agronholm requested review from 1st1 and asvetlov as code owners July 18, 2020 14:33
aeros
aeros reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @agronholm.

+1, loop.connect_accepted_socket() seems to me like it should be included in AbstractEventLoop, as it's important to have for asyncio interoperability purposes when used in addition to other libraries for handling connections. I think you are correct @agronholm that it was simply missed, but I'll wait on approval from @1st1 and/or @asvetlov to confirm this prior to merging.

Also, this should include an update to the What's New document for 3.10, in the "Porting to Python 3.10 > Changes in the Python API" sub-section since it's adding a method to an ABC. See the 3.9 What's New for an example: https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api (since the section doesn't exist yet in the 3.10 version).

@asvetlov @aeros
Update Lib/asyncio/events.py
21fba54 
Co-authored-by: Kyle Stanley <[email protected]>
@asvetlov
Copy link
Contributor

Let's merge as-is.

@asvetlov asvetlov merged commit e3ef4d7 into python:master Nov 26, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@agronholm @asvetlov
@aeros @adorilson
bpo-41332: Added missing connect_accepted_socket() to AbstractEventLo…
a581e7a 
…op (pythonGH-21533)

Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: Kyle Stanley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros aeros left review comments

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agronholm @asvetlov @aeros @the-knights-who-say-ni @bedevere-bot