Skip to content

bpo-41425: Make tkinter doc example runnable #21706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2020
Merged

bpo-41425: Make tkinter doc example runnable #21706

merged 4 commits into from
Aug 3, 2020

Conversation

nerandell
Copy link
Contributor

@nerandell nerandell commented Aug 3, 2020 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nerandell

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 3, 2020
@terryjreedy terryjreedy changed the title bpo-41425: Fix example in tkinter documentation bpo-41425: Make tkinter doc example runnable Aug 3, 2020
@terryjreedy
Copy link
Member

Ankit: since the code you added was, as requested, copied from another example, I consider it 'trivial' enough to merge without your CLA signature. If you had changed the comments to conform to PEP-8, with other slight revisions, as I did, the CLA would have been required. If you intend to ever make another contribution, which I hope you do, please sign the CLA now, if you have not yet, so this will be done before your next PR.

@terryjreedy terryjreedy merged commit c36dbac into python:master Aug 3, 2020
@terryjreedy
Copy link
Member

I first removed the 3-space .rst indents to test the execution of the revised code. I then added them back and rebuilt the docs with the windows equivalent of 'make html' to test the html presentation of the code.

@miss-islington
Copy link
Contributor

Thanks @nerandell for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @nerandell for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-21710 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 3, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2020
@nerandell @miss-islington
bpo-41425: Make tkinter doc example runnable (pythonGH-21706)
b6095ad 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit c36dbac)

Co-authored-by: Ankit Chandawala <[email protected]>
@bedevere-bot
Copy link

GH-21711 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2020
@nerandell @miss-islington
bpo-41425: Make tkinter doc example runnable (pythonGH-21706)
6a0c353 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit c36dbac)

Co-authored-by: Ankit Chandawala <[email protected]>
@terryjreedy
Copy link
Member

The change in the last line of the file ("Constants ...") might have been the addition of a final '\n'. as might be done by patchcheck. There is one now and I don't see any other change.

terryjreedy added a commit that referenced this pull request Aug 3, 2020
@miss-islington @terryjreedy
bpo-41425: Make tkinter doc example runnable (GH-21706)
4bc8445 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit c36dbac)
terryjreedy added a commit that referenced this pull request Aug 3, 2020
@miss-islington @terryjreedy
bpo-41425: Make tkinter doc example runnable (GH-21706)
3c4fc86 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit c36dbac)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@nerandell @terryjreedy @shihai1991
bpo-41425: Make tkinter doc example runnable (pythonGH-21706)
78aeea9 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@nerandell @terryjreedy @shihai1991
bpo-41425: Make tkinter doc example runnable (pythonGH-21706)
0b2ff3b 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@nerandell @terryjreedy
bpo-41425: Make tkinter doc example runnable (pythonGH-21706)
6b38745 
Co-authored-by: Ankit Chandawala <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nerandell @the-knights-who-say-ni @terryjreedy @miss-islington @bedevere-bot