bpo-41424: Remove extra words in Tkinter-Packer documentation #21707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
approved these changes
Aug 3, 2020
| packer takes qualitative relationship specification - *above*, *to the left of*, | ||
| *filling*, etc - and works everything out to determine the exact placement | ||
| coordinates for you. | ||
| are used to specify the relative positioning of widgets within their container - |
There was a problem hiding this comment.
For the future: the source .rst files are not required to have their lines nicely filled out before being wrapped. You could have merely removed the extra from one line and left the rest alone. I then would have been required to check only the one line.
There was a problem hiding this comment.
Thank you for pointing that out @terryjreedy. I appreciate your guidance and will remember that for next time!
terryjreedy
added
needs backport to 3.8
needs backport to 3.9
|
Thanks @nmaynes for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-21708 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 3, 2020
…GH-21707) (cherry picked from commit ecaf949) Co-authored-by: Nathan M <[email protected]>
terryjreedy
changed the title
|
GH-21709 is a backport of this pull request to the 3.8 branch. |
|
There should be a ':' after the issue number. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 3, 2020
…GH-21707) (cherry picked from commit ecaf949) Co-authored-by: Nathan M <[email protected]>
terryjreedy
changed the title
miss-islington
added a commit
that referenced
this pull request
Aug 3, 2020
(cherry picked from commit ecaf949) Co-authored-by: Nathan M <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 3, 2020
(cherry picked from commit ecaf949) Co-authored-by: Nathan M <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41424