-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Document optional 'task'/'asyncgen' fields in call_exception_handler #21735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document optional 'task'/'asyncgen' fields in call_exception_handler #21735
Conversation
Hey @ShaneHarvey, thank you for your PR. There's another key missing at the docs, would you mind adding it as well? cpython/Lib/asyncio/base_events.py Lines 1740 to 1755 in 374d998
|
@rougeth thanks for the the quick review. Updated to include the asyncgen field as well. |
@asvetlov: Please replace |
Thanks! |
this needs a backport to python3.6 |
@graingert 3.6 is EOL so it will not be backported: https://devguide.python.org/devcycle/#end-of-life-branches |
Ah sorry I mean 3.6-3.9 are missing this change - so it should be backported to 3.9 |
Oh that's a good point. I think a CPython maintainer just needs to add the "needs backport to 3.7/8/9" labels. Either that or one of us can create the backport PR manually. |
3.7 & 3.8 are only accepting security-related patches. But 3.9 is still accepting bugfixes and docs patches :) |
Thanks @ShaneHarvey for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-30727 is a backport of this pull request to the 3.9 branch. |
…ythonGH-21735) (cherry picked from commit a1652da) Co-authored-by: Shane Harvey <[email protected]>
…H-21735) (GH-30727) (cherry picked from commit a1652da) Co-authored-by: Shane Harvey <[email protected]> Co-authored-by: Shane Harvey <[email protected]>
…ythonGH-21735) (pythonGH-30727) (cherry picked from commit a1652da) Co-authored-by: Shane Harvey <[email protected]> Co-authored-by: Shane Harvey <[email protected]>
This change documents the optional "task" field in call_exception_handler. For example I noticed this
context
while working on Motor:This change seems trivial enough to not need an issue. Let me know if you disagree and I'll create one.