Skip to content

Update timeit.rst #21744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update timeit.rst #21744

wants to merge 1 commit into from

Conversation

alex-martelli
Copy link

Clarifying that Tim's introduction to "Algorithms" is only in the second edition of "Python Cookbook" (since, alas, it's not in the current, third edition).

Clarifying that Tim's introduction to "Algorithms" is only in the *second* edition of "Python Cookbook" (since, alas, it's not in the current, third edition).
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@alex-martelli

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

Patches go to master branch to be backported back to the relevant branches. Please see https://devguide.python.org/pullrequest/

@iritkatriel
Copy link
Member

Sorry, it looked like a good idea at the time.

@ned-deily
Copy link
Member

ned-deily commented May 19, 2021

Since the PR was originally (incorrectly) against the 3.8 branch, it's probably easier and safer to just cherry-pick the change to a new PR against main and auto back port to 3.10 and 3.9 now and close this PR.

@iritkatriel
Copy link
Member

There's still the CLA not signed issue as well.

@iritkatriel
Copy link
Member

And I haven't checked the book myself to verify this change.

@ned-deily
Copy link
Member

ned-deily commented May 19, 2021

As a core developer, it looks like Alex does have a signed contributor agreement from way back but it is associated on bpo with a different GitHub name, @aleaxit. The bpo entry could be changed to link to @alex-martelli; AFAIK, it's only possible for a bpo user to be associated with one GitHub account. It's a bit of a nit, of course. Alex, any preference?

@gvanrossum
Copy link
Member

gvanrossum commented May 19, 2021 via email

@terryjreedy
Copy link
Member

terryjreedy commented May 19, 2021

CLA is not needed for such a trivial commit, especially a data correction.
Since 1st edition did not have Tim's intro, 'the second edition' should have been there from the start,
and would be true now regardless of 3rd edition.
The current doc can be edited in main without cherry-pick.
I asked on python-list for any 3rd edition owners to verify the deletion.

@terryjreedy
Copy link
Member

  1. Algorithms with Tim's intro is now 1. Data Structures and Algorithms, without. Half of Tim's 4 1/2 pages discussed classic algorithm references; the other half timeit, with bits dated. I looked through the doc chapter to see if there was anything really essential missing and decided not. Specify Python Cookbook edition for reference #26301 replaces this.

Irit, thank you for trolling through 'stale' PRs like this so we can try to dispose of them one way or another. In the future, you can ask me to help without the accidental mass review request ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants