-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Update timeit.rst #21744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update timeit.rst #21744
Conversation
Clarifying that Tim's introduction to "Algorithms" is only in the *second* edition of "Python Cookbook" (since, alas, it's not in the current, third edition).
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Patches go to master branch to be backported back to the relevant branches. Please see https://devguide.python.org/pullrequest/ |
Sorry, it looked like a good idea at the time. |
Since the PR was originally (incorrectly) against the 3.8 branch, it's probably easier and safer to just cherry-pick the change to a new PR against main and auto back port to 3.10 and 3.9 now and close this PR. |
There's still the CLA not signed issue as well. |
And I haven't checked the book myself to verify this change. |
As a core developer, it looks like Alex does have a signed contributor agreement from way back but it is associated on bpo with a different GitHub name, @aleaxit. The bpo entry could be changed to link to @alex-martelli; AFAIK, it's only possible for a bpo user to be associated with one GitHub account. It's a bit of a nit, of course. Alex, any preference? |
Someone should at least ask Alex if this is him. Anybody can create a
GitHub account named Alex Martelli and add a photo of Alex to it... (And
IIRC GitHub frowns upon people having multiple accounts.)
|
CLA is not needed for such a trivial commit, especially a data correction. |
Irit, thank you for trolling through 'stale' PRs like this so we can try to dispose of them one way or another. In the future, you can ask me to help without the accidental mass review request ;-). |
Clarifying that Tim's introduction to "Algorithms" is only in the second edition of "Python Cookbook" (since, alas, it's not in the current, third edition).