Skip to content

Update documentation of logging.Filter.filter() #22692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Update documentation of logging.Filter.filter() #22692

merged 1 commit into from
Oct 16, 2020

Conversation

soulmerge
Copy link
Contributor

@soulmerge soulmerge commented Oct 14, 2020 •
edited by bedevere-bot
Loading

bpo-42011: Update documentation of logging.Filter.filter()

@soulmerge soulmerge requested a review from vsajip as a code owner October 14, 2020 08:02
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@soulmerge

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JulienPalard
Copy link
Member

Thanks for this PR!

LGTM, don't forget to sign the CLA.

Seluj78
Seluj78 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your documentation improvement !

@Pyrex421
Copy link

bpo-42011: Update documentation of logging.Filter.filter()

vsajip
vsajip requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but the CLA needs to be signed before this PR can be merged. Currently, it's still showing as not signed.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@soulmerge
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip October 16, 2020 07:59
@vsajip vsajip merged commit e9959c7 into python:master Oct 16, 2020
@miss-islington
Copy link
Contributor

Thanks @soulmerge for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @soulmerge for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22724 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2020
@soulmerge @miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
ad67b7e 
…22692)

(cherry picked from commit e9959c7)

Co-authored-by: Necdet Can Atesman <[email protected]>
@bedevere-bot
Copy link

GH-22725 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2020
@soulmerge @miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
0472c8c 
…22692)

(cherry picked from commit e9959c7)

Co-authored-by: Necdet Can Atesman <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 16, 2020
vsajip pushed a commit that referenced this pull request Oct 16, 2020
@miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (…
8f7eab7 
…GH-22724)

(cherry picked from commit e9959c7)
vsajip pushed a commit that referenced this pull request Oct 16, 2020
@miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (…
dff9161 
…GH-22725)

(cherry picked from commit e9959c7)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@soulmerge
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
3be2475 
…22692)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@soulmerge @adorilson
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
7cf963d 
…22692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seluj78 Seluj78 Seluj78 approved these changes

@vsajip vsajip Awaiting requested review from vsajip

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@soulmerge @the-knights-who-say-ni @JulienPalard @Pyrex421 @bedevere-bot @miss-islington @vsajip @Seluj78