bpo-19270: Fixed sched.scheduler.cancel to cancel correct event #22729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDarmoutomo
approved these changes
Oct 16, 2020
|
@rhettinger Implemented as you've suggested. Will break a few eggs if developers are counting on internal details of the module but it shouldn't be an issue. Should I add a notice about it somewhere? On migration changelog / sched module? |
Misc/NEWS.d/next/Library/2020-10-16-22-48-01.bpo-19270.jd_gkA.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Serhiy Storchaka <[email protected]>
|
@serhiy-storchaka All fixed, ready for merge. Thanks for using the suggested changes feature. Didn't know it exists. Awesome 😄 |
serhiy-storchaka
approved these changes
Oct 19, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue19270