Minor tweaks to typing union objects doc #22741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
Oct 18, 2020
There was a problem hiding this comment.
LGTM. I had originally used 'Union Object' but changed it to 'union object' to keep it consistent with typing.Union's docs in #22517. Which I then proceeded to forget to apply in some places. Thanks for the catch!
|
does this need backports? |
|
@merwok No, the union object only exists in 3.10. |
merwok
changed the title
merwok
approved these changes
Oct 20, 2020
|
Thanks to you both! |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Automerge-Triggered-By: @merwok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: @merwok