Skip to content

bpo-41471: Ignore invalid prefix lengths in system proxy settings on … #22762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Oct 19, 2020

Ignore invalid prefix lengths (such as '172.19.0.0/40') in the system proxy settings on macOS. This matches the behaviour of Safari.

https://bugs.python.org/issue41471

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
…macOS (pythonGH-22762)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 19, 2020
@bedevere-bot
Copy link

GH-22773 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
…macOS (pythonGH-22762)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <[email protected]>
@bedevere-bot
Copy link

GH-22774 is a backport of this pull request to the 3.8 branch.

ronaldoussoren added a commit that referenced this pull request Oct 20, 2020
…macOS (GH-22762) (GH-22773)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <[email protected]>
ronaldoussoren added a commit that referenced this pull request Oct 20, 2020
…macOS (GH-22762) (GH-22774)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants