Skip to content

[doc] Fix smtplib and xml.dom.minidom mark-up #22769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2020
Merged

[doc] Fix smtplib and xml.dom.minidom mark-up #22769

merged 3 commits into from
Nov 18, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Oct 19, 2020 •
edited
Loading

Compare SMTP_SSL and LMTP to see the difference:
https://docs.python.org/3/library/smtplib.html

Compare unlink and writexml/toprettyxml to see the difference:
https://docs.python.org/3/library/xml.dom.minidom.html

@andresdelfino andresdelfino requested a review from a team as a code owner October 19, 2020 16:14
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 19, 2020
@andresdelfino andresdelfino changed the title [doc] Fix LMTP mark-up [doc] Fix smtplib and xml.dom.minidom mark-up Oct 19, 2020
@JulienPalard JulienPalard added the needs backport to 3.9 only security fixes label Nov 18, 2020
@JulienPalard JulienPalard merged commit 829b177 into python:master Nov 18, 2020
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@JulienPalard
Copy link
Member

Thanks @andresdelfino, nice spot :)

@miss-islington
Copy link
Contributor

Sorry @andresdelfino and @JulienPalard, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 829b177436e091025813d9be28c21ca46f246af7 3.9

@bedevere-bot
Copy link

GH-23380 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 18, 2020
JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request Nov 18, 2020
@andresdelfino @JulienPalard
[3.9] [doc] Fix smtplib and xml.dom.minidom mark-up (pythonGH-22769)
bc78a26 
(cherry picked from commit 829b177)

Co-authored-by: Andre Delfino <[email protected]>
@andresdelfino andresdelfino deleted the fix_LMTP branch November 18, 2020 22:50
JulienPalard added a commit that referenced this pull request Dec 1, 2020
@JulienPalard
[3.9] [doc] Fix smtplib and xml.dom.minidom mark-up (GH-22769) (GH-23380
7e80c0f 
)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
[doc] Fix smtplib and xml.dom.minidom mark-up (pythonGH-22769)
70a1f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

@JulienPalard JulienPalard

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresdelfino @miss-islington @JulienPalard @bedevere-bot @tirkarthi @the-knights-who-say-ni