Skip to content

bpo-41910: specify the default implementations of object.__eq__ and object.__ne__ #22874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 21, 2020

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

https://bugs.python.org/issue41910

Automerge-Triggered-By: GH:brettcannon

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@miss-islington
Copy link
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22876 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2020
…bject.__ne__ (pythonGH-22874)

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

Automerge-Triggered-By: GH:brettcannon
(cherry picked from commit 3c69f0c)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-bot
Copy link

GH-22877 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2020
…bject.__ne__ (pythonGH-22874)

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

Automerge-Triggered-By: GH:brettcannon
(cherry picked from commit 3c69f0c)

Co-authored-by: Brett Cannon <[email protected]>
terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
…bject.__ne__ (GH-22874) (#22876)

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

Co-authored-by: Brett Cannon <[email protected]>
terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
…bject.__ne__ (GH-22874) (#22877)

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

Co-authored-by: Brett Cannon <[email protected]>
@brettcannon brettcannon deleted the __eq__-default branch October 22, 2020 02:06
@GPHemsley
Copy link
Contributor

Shouldn't the changelog entry be in Documentation?

@terryjreedy
Copy link
Member

Yes. Brett, I will fix the appropriate files in Misc/NEWS.d

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…bject.__ne__ (pythonGH-22874)

See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.

Automerge-Triggered-By: GH:brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants