Skip to content

bpo-42150: Avoid buffer overflow in the new parser #22978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2020
Merged

bpo-42150: Avoid buffer overflow in the new parser #22978

merged 1 commit into from
Oct 25, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 25, 2020 •
edited by bedevere-bot
Loading

With this PR:

❯ ./python -m test test_repl -v
== CPython 3.10.0a1+ (heads/master-dirty:d1a0a960ee, Oct 25 2020, 21:09:15) [GCC 10.2.0]
== Linux-5.4.72-1-MANJARO-x86_64-with-glibc2.32 little-endian
== cwd: /home/pablogsal/github/python/master/build/test_python_32693æ
== CPU count: 36
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 1.78 Run tests sequentially
0:00:00 load avg: 1.78 [1/1] test_repl
test_close_stdin (test.test_repl.TestInteractiveInterpreter) ... ok
test_multiline_string_parsing (test.test_repl.TestInteractiveInterpreter) ... ok
test_no_memory (test.test_repl.TestInteractiveInterpreter) ... ok

----------------------------------------------------------------------

Ran 3 tests in 0.341s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 424 ms
Tests result: SUCCESS

https://bugs.python.org/issue42150

@pablogsal pablogsal added needs backport to 3.9 only security fixes and removed awaiting core review labels Oct 25, 2020
@pablogsal
Copy link
Member Author

I am merging this as this is a straightforward fix and I want the buildbots to be fixed

@pablogsal pablogsal merged commit e68c678 into python:master Oct 25, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2020
@pablogsal @miss-islington
bpo-42150: Avoid buffer overflow in the new parser (pythonGH-22978)
ccf45c2 
(cherry picked from commit e68c678)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 25, 2020
@bedevere-bot
Copy link

GH-22979 is a backport of this pull request to the 3.9 branch.

@pablogsal pablogsal deleted the bpo-42150 branch October 25, 2020 23:08
miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @pablogsal
bpo-42150: Avoid buffer overflow in the new parser (GH-22978)
0b290dd 
(cherry picked from commit e68c678)

Co-authored-by: Pablo Galindo <[email protected]>
@python python deleted a comment from bedevere-bot Oct 26, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-42150: Avoid buffer overflow in the new parser (pythonGH-22978)
d580aaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni